Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark Theme support #112

Closed
shayc opened this issue Nov 18, 2017 · 2 comments · Fixed by #671
Closed

Dark Theme support #112

shayc opened this issue Nov 18, 2017 · 2 comments · Fixed by #671
Assignees
@martinbedouret
Labels
feature
Milestone
1.3.0

Comments

@shayc
Copy link
Collaborator

shayc commented Nov 18, 2017 •
edited
Loading

We want to support themes (dark theme for example).

We will need to create dark and white themes using ThemeProvider (already implemented using material-ui)
We will need to create a UI toggle to switch between dark/white themes at the settings screen.
Settings screen will need an "Appearance" settings page, and in there a toggle to switch.
Tip: Check how the other pages in the settings folder are built.
@shayc shayc removed the goodness label Jan 25, 2018
@shayc
Copy link
Collaborator Author

shayc commented Feb 20, 2018

I'm taking this!

@shayc shayc changed the title [material-ui] add Theme support Theme support Nov 20, 2018
@martinbedouret martinbedouret linked a pull request Apr 1, 2020 that will close this issue
Push dark theme #671
Merged
@martinbedouret martinbedouret self-assigned this Apr 1, 2020
@martinbedouret
Copy link
Collaborator

martinbedouret commented Apr 1, 2020 •
edited
Loading

below some captures:

image

image

image

image

image

@martinbedouret martinbedouret added this to the 1.2.1 milestone Apr 1, 2020
@martinbedouret martinbedouret changed the title Theme support Dark Theme support Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martinbedouret martinbedouret

Labels
feature
Projects
None yet
Milestone
1.3.0
Development

Successfully merging a pull request may close this issue.

Push dark theme cboard-org/cboard
2 participants
@shayc @martinbedouret