Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Push dark theme #671

Merged
merged 14 commits into from
Apr 3, 2020
Merged

Push dark theme #671

merged 14 commits into from
Apr 3, 2020

Conversation

martinbedouret
Copy link
Collaborator

No description provided.

@martinbedouret martinbedouret added this to the 1.2.1 milestone Apr 1, 2020
@martinbedouret martinbedouret self-assigned this Apr 1, 2020
@martinbedouret martinbedouret linked an issue Apr 1, 2020 that may be closed by this pull request
Dark Theme support #112
Closed
@shayc
Copy link
Collaborator

shayc commented Apr 2, 2020

Heya, will review later today :)

shayc
shayc requested changes Apr 2, 2020
View reviewed changes
Copy link
Collaborator

@shayc shayc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, the only issue I have is with the class names. I'll try to push to this branch and fix the issues myself. Good job man.

src/components/Board/Navbar/Navbar.css Outdated Show resolved Hide resolved
src/components/Board/Navbar/Navbar.js Outdated Show resolved Hide resolved
src/components/Board/Output/SymbolOutput/SymbolOutput.css Outdated Show resolved Hide resolved
src/components/Communicator/CommunicatorDialog/CommunicatorDialog.component.js Outdated Show resolved Hide resolved
@shayc
Copy link
Collaborator

shayc commented Apr 2, 2020 •
edited
Loading

@martinbedouret I fixed the stuff in the code review, it's in PR #672
If you'll accept the changes, you'll need to merge that PR to this branch and then to master.
The reason I opened another PR rather than push straight to your branch is so you can see the changes I've made,

@martinbedouret
Copy link
Collaborator Author

fantastic feedback @shayc !! I did apply a couple of fixes as well !

@martinbedouret martinbedouret merged commit 320766a into master Apr 3, 2020
@martinbedouret martinbedouret deleted the push-dark-theme branch April 3, 2020 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shayc shayc shayc requested changes

@kidcompassion kidcompassion Awaiting requested review from kidcompassion

Assignees

@martinbedouret martinbedouret

Labels
feature
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

Dark Theme support
2 participants
@martinbedouret @shayc