Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep embedded images when importing an OBF board that contains embedded images #756

Closed
martinbedouret opened this issue Jul 24, 2020 · 0 comments · Fixed by #760
Closed

Keep embedded images when importing an OBF board that contains embedded images #756

martinbedouret opened this issue Jul 24, 2020 · 0 comments · Fixed by #760
Assignees
@sylvansson
Labels
feature
Milestone
1.6.0

Comments

@martinbedouret
Copy link
Collaborator

Currently, when a user imports an OBF board that contains embedded images, we save those images in the cloud and we replace the tile image by a reference to the file in the cloud. That affects to the offline users as the cloud images won't be displayed.
The initial solution would be to simply keep embedded images in such format data:image/... but I am open to any other suggestion.
@martinbedouret martinbedouret added this to the 1.6.0 milestone Jul 24, 2020
sylvansson added a commit that referenced this issue Jul 25, 2020
@sylvansson
#756 Get extension with mime-types library
c7868bc
sylvansson added a commit that referenced this issue Jul 25, 2020
@sylvansson
#756 Set content type properly during export
919d3a6
sylvansson added a commit that referenced this issue Jul 25, 2020
@sylvansson
#756 Use ObjectId as image identifier
78e32a7 
This commit updates the export logic to use an ObjectId as an image
identifier and to solve two issues:

1. We no longer have an extremely long id when the `image` property
   is a data URI like `data:image/png;base64,iVBORw0K`.
2. We now have consistent image ids between `manifest.json` and the
   OBF files, as required by the Open Board Format.
sylvansson added a commit that referenced this issue Jul 25, 2020
@sylvansson
#756 Do not upload images when importing from OBF
b9ce2ad
@sylvansson sylvansson mentioned this issue Jul 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sylvansson sylvansson

Labels
feature
Projects
None yet
Milestone
1.6.0
Development

Successfully merging a pull request may close this issue.

Store images as data URIs when importing from OBF/OBZ cboard-org/cboard
2 participants
@martinbedouret @sylvansson