Bug/edit mode doble link #1101
Merged
Bug/edit mode doble link #1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RodriSanchez1
commented
Dec 13, 2021
martinbedouret
requested changes
Dec 20, 2021
| @@ -1614,7 +1614,12 @@ export class BoardContainer extends Component { | |||
| onClose={this.handleTileEditorCancel} | |||
| onEditSubmit={this.handleEditTileEditorSubmit} | |||
| onAddSubmit={this.handleAddTileEditorSubmit} | |||
| boards={this.props.boards} | |||
| boards={this.props.boards.filter( | |||
There was a problem hiding this comment.
this Looks incorrect to me. The boards included in the default cboard are not owned by the user who logged in. You should not filter boards.
There was a problem hiding this comment.
If you dont filter, the select will show all the boards in boards state. That contains the boards created before the user log in and the boards created after the user log in. The filter takes only the user boards.
In the image you can see two home boards. You can check this issue, its a similar problem #1102
| @@ -414,12 +412,19 @@ export class TileEditor extends Component { | |||
| this.updateTileProperty('image', image); | |||
| }; | |||
|
|
|||
| linkedBoard = () => { | |||
There was a problem hiding this comment.
to me, the linked board looks an internal state of the component.
martinbedouret
approved these changes
Jan 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1088 and close #1070