Show password feature #1463
Closed
Show password feature #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
awesome @arjunanand23 ! |
shayc
reviewed
May 24, 2024
| endAdornment: <InputAdornment position="end"> | ||
| <IconButton | ||
| aria-label="toggle password visibility" | ||
| onClick={() => { showPassword = !showPassword; }} |
There was a problem hiding this comment.
this line is problematic, updating a variable instead of state
tomivm
requested changes
May 24, 2024
| @@ -49,6 +59,8 @@ export class Login extends Component { | |||
|
|
|||
| const isButtonDisabled = isLogging || !!loginStatus.success; | |||
|
|
|||
| var showPassword = false; | |||
There was a problem hiding this comment.
A state should be used for this. This is the reason why you need to type a new character to see the password.
|
completed on #1700 PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempted to add feature where password could be shown/hidden. Currently works if another character is entered but does not take place immediately.