Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/refactor get subscriber not found #1551

Conversation

RodriSanchez1
Copy link
Collaborator

@RodriSanchez1 RodriSanchez1 commented Jul 21, 2023

On this PR:

  • Check in getSubscriber() request if the response have the succes prop, if not or is false throw the response data
  • Support old behaviour for Android <1.31.0 versions

Also see on CboardAPI PR - Fix/Refactor get subscriber

@martinbedouret martinbedouret added this to the 1.31.0 milestone Jul 27, 2023
@RodriSanchez1 RodriSanchez1 marked this pull request as ready for review August 1, 2023 16:00
@RodriSanchez1
Copy link
Collaborator Author

close #1532

@martinbedouret martinbedouret modified the milestones: 1.31.0, 1.32.0 Aug 29, 2023
@martinbedouret martinbedouret modified the milestones: 1.32.0, 1.33.0 Nov 17, 2023
@martinbedouret martinbedouret merged commit 0d3c5d5 into cboard-org:master Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor frontend and back-end to avoid 404 error in case a subscriber is not found
2 participants