Fix/redirect to login page after activate an account #1553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinbedouret
requested changes
Jul 31, 2023
There was a problem hiding this comment.
@tomivm please refactor this to a simpler strategy: just redirect the user to the login page once the activation is done successfully. No API changes required.
tomivm
changed the title
|
@martinbedouret Now any change on the API is needed and the user is not logged in automatically. Users are redirected to the login-signup view and the messages on the Activate component are ready to be translated |
martinbedouret
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR the Activate container is prepared to keep the user logged in after activating an account. it needs an update on the API => cboard-org/cboard-api#308
It should be tested on Android with the universal Link feature.
Close #1342