Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump/nodejs v18 #1595

Merged
merged 34 commits into from
Dec 8, 2023
Merged

Conversation

RodriSanchez1
Copy link
Collaborator

@RodriSanchez1 RodriSanchez1 commented Oct 18, 2023

On this PR:

  • Node version was updated to v18.18.1. The new version was pinned on docker file, .nvmrc and CI config.
  • React-scripts package was updated to v5. This changes comes with an upgrade of Webpack to v5. To make all works properly, the CRACO package was added for config webpack avoiding to eject.
    NOTE: We are currently react-rewire (similiar than CRACO) but is not maintened anymore. Needs to migrate.
  • Change option --maxWorkers=50% for --runInBand on CI config. This change was made because the Unit Test were hanging with no output response. Also increment the run speed of the test.
  • Fix default export on Import.constants.js and Export.helpers.js
  • Ignore url webpack resolution on WelcomeScreen.css
  • Fix openDb import on arasaac.ts
  • Update yarn.lock file

@RodriSanchez1 RodriSanchez1 marked this pull request as ready for review October 20, 2023 15:21
@martinbedouret
Copy link
Collaborator

@RodriSanchez1 Shouldn't we remove the react-scripts package?

@martinbedouret
Copy link
Collaborator

@RodriSanchez1 Just installed dependencies and run and got the following error:

image

@RodriSanchez1
Copy link
Collaborator Author

@RodriSanchez1 Shouldn't we remove the react-scripts package?

No, we still use it. But an update to react-scripts was needed to support Node v18.
I'm planning to migrate to Vite and then we can remove it.

@RodriSanchez1 Just installed dependencies and run and got the following error:

Do you change your node version to v18.18.1 before build? On my pc is building well.

package.json Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
"start": "react-scripts start",
"build": "react-scripts build && sw-precache --config=sw-precache-config.js",
"start": "craco start",
"build": "craco build && sw-precache --config=sw-precache-config.js",
"build-cordova-debug": "react-app-rewired build",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is react-app-rewired needed? can you use craco instead? (i'm not sure)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we can remove it. I will do that in other PR

craco.config.js Outdated Show resolved Hide resolved
.circleci/config.yml Show resolved Hide resolved
.nvmrc Outdated Show resolved Hide resolved
@martinbedouret martinbedouret added this to the 1.33.0 milestone Nov 17, 2023
@martinbedouret martinbedouret merged commit 9b9f835 into cboard-org:master Dec 8, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants