Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add only necessary default boards on login #1711

Merged
merged 40 commits into from
Jul 3, 2024
Merged

Feature/add only necessary default boards on login #1711

merged 40 commits into from
Jul 3, 2024

Conversation

tomivm
Copy link
Collaborator

@tomivm tomivm commented Jun 14, 2024

This PR has the objective of including only the necessary default boards on the user's login.
Also, have changes to be sure that these boards would be added if the user requests it and aren't correctly added.
Please take a strong test!
close #1710

tomivm added 15 commits June 11, 2024 17:20
@tomivm
Add actions to clean all boards and add the necessary default boards
05568ae
@tomivm
Clean All boards from the store before loginSuccess
c0a07cb
@tomivm
Add root board if is not on the communicator boards before login success
ae9e5da
@tomivm
Fix addRootBoard import
69f5bee
@tomivm
refactor: Update addRootBoard import and function name to addRootBoar…
bec7283 
…dFromDefaultBoards
@tomivm
refactor: Rename addRootBoard function to findAndAddRootBoardOnDefaul…
408fba8 
…tBoards
@tomivm
Refactor login to add necessary default boards for homeBoards
360aa9e
@tomivm
Add necessary default boards for remote boards
15ba033
@tomivm
Prevent unnecessary requests to get boards for local Ids
2aeeb4a
@tomivm
Add necessary Default boards on changeDefaultBoard
1dcf25e
@tomivm
Enforces the possibilities to find the home board if it is requested
2cca7af
@tomivm
Fix incorrect map to search ids on ALL_DEFAULT_BOARDS
f1e3fcf
@tomivm
Create helper function to check if id is Remote
ee8c86c
@tomivm
Add insurance to find Default Boards on a folder click
3a7b973
@tomivm
use remoteIdChecker helper function
0f7c473
@tomivm tomivm added the feature label Jun 14, 2024
@tomivm tomivm self-assigned this Jun 14, 2024
@tomivm
Copy link
Collaborator Author

tomivm commented Jun 27, 2024 •
edited
Loading

@RodriSanchez1 Please check the new changes. I improved the way to remove the unnecessary default boards. This changes on the API are needed cboard-org/cboard-api#360

@tomivm tomivm mentioned this pull request Jun 27, 2024
Merged
@tomivm tomivm merged commit 8592f43 into cboard-org:master Jul 3, 2024
5 checks passed
@tomivm tomivm deleted the feature/add-only-necessary-default-boards-on-login branch July 3, 2024 23:51
RodriSanchez1 added a commit to RodriSanchez1/cboard that referenced this pull request Jul 23, 2024
@RodriSanchez1
Revert "Merge pull request cboard-org#1711 from tomivm/feature/add-on…
78f1d91 
…ly-necessary-default-boards-on-login"

This reverts commit 8592f43, reversing
changes made to 42c1242.
RodriSanchez1 added a commit that referenced this pull request Jul 24, 2024
@RodriSanchez1
Merge pull request #1744 from RodriSanchez1/removeBlacklist
cfc9c27 
Revert "Merge pull request #1711 from tomivm/feature/add-only-necessary-default-boards-on-login"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RodriSanchez1 RodriSanchez1 RodriSanchez1 left review comments

@martinbedouret martinbedouret Awaiting requested review from martinbedouret

Assignees

@tomivm tomivm

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add just the necessary default boards on user login
2 participants
@tomivm @RodriSanchez1