Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix / Create neccesary default boards on DB #1743

Merged
merged 4 commits into from
Jul 23, 2024
Merged

Fix / Create neccesary default boards on DB #1743

merged 4 commits into from
Jul 23, 2024

Conversation

RodriSanchez1
Copy link
Collaborator

@RodriSanchez1 RodriSanchez1 commented Jul 23, 2024 •
edited
Loading

Comprobe if an API board contains the tile ID of a default board before marking it to create. Maybe with this solution we can avoid the creation of the defaultBoardBlackList

@RodriSanchez1 RodriSanchez1 requested a review from tomivm July 23, 2024 02:27
tomivm
tomivm approved these changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@tomivm tomivm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! it's a better solution than using a blacklist. I agree that with these changes we can avoid the creation of the defaultBoardBlackList.

@RodriSanchez1 RodriSanchez1 merged commit 3bbb425 into cboard-org:master Jul 23, 2024
2 of 4 checks passed
@RodriSanchez1 RodriSanchez1 deleted the fixes branch July 23, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomivm tomivm tomivm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RodriSanchez1 @tomivm