Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show loading state on remote boards copy #1750

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 23 additions & 9 deletions src/components/Board/Board.container.js
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ import {
IS_BROWSING_FROM_APPLE_TOUCH,
IS_BROWSING_FROM_SAFARI
} from '../../constants';
import LoadingIcon from '../UI/LoadingIcon';
//import { isAndroid } from '../../cordova-util';

const ogv = require('ogv');
Expand Down Expand Up @@ -1183,6 +1184,9 @@ export class BoardContainer extends Component {
handleCopyRemoteBoard = async () => {
const { intl, showNotification, history, switchBoard } = this.props;
try {
this.setState({
isSaving: true
});
const copiedBoard = await this.createBoardsRecursively(
this.state.copyPublicBoard
);
Expand All @@ -1194,15 +1198,18 @@ export class BoardContainer extends Component {
const translatedBoard = this.translateBoard(copiedBoard);
this.setState({
translatedBoard,
isSaving: false,
copyPublicBoard: false,
blockedPrivateBoard: false
});
showNotification(intl.formatMessage(messages.boardCopiedSuccessfully));
} catch (err) {
console.log(err.message);
showNotification(intl.formatMessage(messages.boardCopyError));
this.handleCloseDialog();
}
this.setState({
isSaving: false
});
};

async createBoardsRecursively(board, records) {
Expand Down Expand Up @@ -1264,10 +1271,6 @@ export class BoardContainer extends Component {

// Loggedin user?
if ('name' in userData && 'email' in userData) {
this.setState({
isSaving: true
});

try {
const boardId = await updateApiObjectsNoChild(newBoard, true);
newBoard = {
Expand All @@ -1290,7 +1293,7 @@ export class BoardContainer extends Component {
const nextBoard = await API.getBoard(tile.loadBoard);
await this.createBoardsRecursively(nextBoard, records);
} catch (err) {
if (err.response.status === 404) {
if (!err.respose || err.response?.status === 404) {
//look for this board in available boards
const localBoard = boards.find(b => b.id === tile.loadBoard);
if (localBoard) {
Expand Down Expand Up @@ -1348,7 +1351,9 @@ export class BoardContainer extends Component {
});
}

handleCloseDialog = () => {
handleCloseDialog = (event, reason) => {
const { isSaving } = this.state;
if (isSaving) return;
this.setState({
copyPublicBoard: false,
blockedPrivateBoard: false
Expand Down Expand Up @@ -1611,16 +1616,25 @@ export class BoardContainer extends Component {
</DialogContentText>
</DialogContent>
<DialogActions>
<Button onClick={this.handleCloseDialog} color="primary">
<Button
onClick={this.handleCloseDialog}
color="primary"
disabled={this.state.isSaving}
>
{this.props.intl.formatMessage(messages.boardCopyCancel)}
</Button>
<PremiumFeature>
<Button
onClick={this.handleCopyRemoteBoard}
color="primary"
variant="contained"
disabled={this.state.isSaving}
>
{this.props.intl.formatMessage(messages.boardCopyAccept)}
{this.state.isSaving ? (
<LoadingIcon />
) : (
this.props.intl.formatMessage(messages.boardCopyAccept)
)}
</Button>
</PremiumFeature>
</DialogActions>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -293,20 +293,13 @@ class CommunicatorDialogContainer extends React.Component {
// Loggedin user?
if ('name' in userData && 'email' in userData) {
try {
this.setState({
loading: true
});
const boardId = await updateApiObjectsNoChild(newBoard, true);
newBoard = {
...newBoard,
id: boardId
};
} catch (err) {
console.log(err.message);
} finally {
this.setState({
loading: false
});
}
}

Expand All @@ -321,7 +314,7 @@ class CommunicatorDialogContainer extends React.Component {
const nextBoard = await API.getBoard(tile.loadBoard);
await this.createBoardsRecursively(nextBoard, records);
} catch (err) {
if (err.response.status === 404) {
if (!err.respose || err.response?.status === 404) {
//look for this board in available boards
const localBoard = availableBoards.find(
b => b.id === tile.loadBoard
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ import TextField from '@material-ui/core/TextField';
import CircularProgress from '@material-ui/core/CircularProgress';
import Slide from '@material-ui/core/Slide';
import DialogContentText from '@material-ui/core/DialogContentText';
import LoadingIcon from '../../UI/LoadingIcon';

import IconButton from '../../UI/IconButton';
import { TAB_INDEXES } from './CommunicatorDialog.constants';
Expand Down Expand Up @@ -73,6 +74,8 @@ class CommunicatorDialogBoardItem extends React.Component {
? props.board.description
: ''
};

this.handleDialogClose = this.handleDialogClose.bind(this);
}

openMenu(e) {
Expand Down Expand Up @@ -149,14 +152,14 @@ class CommunicatorDialogBoardItem extends React.Component {

async handleBoardCopy(board) {
this.setState({
openCopyBoard: false,
loading: true
});
try {
await this.props.copyBoard(board);
} catch (err) {
} finally {
this.setState({
openCopyBoard: false,
loading: false
});
}
Expand Down Expand Up @@ -839,7 +842,9 @@ class CommunicatorDialogBoardItem extends React.Component {
</Dialog>

<Dialog
onClose={this.handleDialogClose.bind(this)}
onClose={() => {
if (!this.state.loading) this.handleDialogClose();
}}
aria-labelledby="board-copy-dialog"
open={this.state.openCopyBoard}
>
Expand All @@ -858,6 +863,7 @@ class CommunicatorDialogBoardItem extends React.Component {
<Button
onClick={this.handleDialogClose.bind(this)}
color="primary"
disabled={this.state.loading}
>
{intl.formatMessage(messages.close)}
</Button>
Expand All @@ -868,8 +874,13 @@ class CommunicatorDialogBoardItem extends React.Component {
}}
variant="contained"
color="primary"
disabled={this.state.loading}
>
{intl.formatMessage(messages.accept)}
{this.state.loading ? (
<LoadingIcon />
) : (
intl.formatMessage(messages.accept)
)}
</Button>
</PremiumFeature>
</DialogActions>
Expand Down
Loading