Fix #1774 #1776
Merged
Fix #1774 #1776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug described in issue #1774 only happens when the scanning mode's scanning method is set to automatic, whereas the problem was that the Tile's onClick event was being fired twice when the output bar was empty.
Upon lots of debugging, I could state that this wasn't being caused by the events bubbling up (in both times the event's target and currentTarget were the same).
The culprit may lie in how the Scanner's automatic strategy handles the click event or the alternating DOM.
This PR fixes the issue by ensuring that the onClick event runs once, and only once.