Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to your
feature/fixed-board
branch:It contains an updated
FixedGrid
component with drag and drop support, instead of relying onreact-obf
, which I'm not sure I'll maintain. the code will be in Cboard, this way if there's a bug, a maintainer wouldn't need to clone another repository and walk through the process of publishing a new version on npm.Changes in this pr:
react-obf
npm packageFixedGrid
component (backward compatible withreact-obf
API)react-dnd
npm package (for drag and drop)Todo:
HTML5Backend
, unfortunately it doesn't support touch, need to useTouchBackend
instead - https://react-dnd.github.io/react-dnd/docs/backends/touchnewOrder
initially doesn't contain all tileid
s. I guess there's a bug/not implemented when creating initialorder
?updateBoard
andsaveApiBoardOperation
but new grid state isn't reflected in the UI