Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fixed board shay #803

Merged
merged 5 commits into from
Nov 26, 2020

Conversation

shayc
Copy link
Collaborator

@shayc shayc commented Nov 25, 2020

This is a PR to your feature/fixed-board branch:

It contains an updated FixedGrid component with drag and drop support, instead of relying on react-obf, which I'm not sure I'll maintain. the code will be in Cboard, this way if there's a bug, a maintainer wouldn't need to clone another repository and walk through the process of publishing a new version on npm.

Changes in this pr:

  • Add TypeScript support - it doesn't mean we need to write in TypeScript, just that if someone wants to they can.
  • Use CSS Modules
  • Removed react-obf npm package
  • Add FixedGrid component (backward compatible with react-obf API)
  • Add react-dnd npm package (for drag and drop)

Todo:

  • Fix: Drag and drop uses HTML5Backend, unfortunately it doesn't support touch, need to use TouchBackend instead - https://react-dnd.github.io/react-dnd/docs/backends/touch
  • Fix: newOrder initially doesn't contain all tile ids. I guess there's a bug/not implemented when creating initial order?
    image
  • Fix: After dropping a Tile, the board is saved with updateBoard and saveApiBoardOperation but new grid state isn't reflected in the UI
  • Tests?

@shayc shayc requested review from sylvansson and removed request for sylvansson November 26, 2020 00:01
@martinbedouret martinbedouret merged commit 1484e4b into feature/fixed-board Nov 26, 2020
@martinbedouret martinbedouret deleted the feature/fixed-board-shay branch November 29, 2020 19:24
@martinbedouret martinbedouret linked an issue Dec 4, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New fixed board and grid
2 participants