Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shared boards have some titles of symbols translated back to English #814

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Shared boards have some titles of symbols translated back to English #814

merged 1 commit into from
Dec 11, 2020

Conversation

martinbedouret
Copy link
Collaborator

No description provided.

@martinbedouret martinbedouret added this to the 1.7.1 milestone Dec 8, 2020
@martinbedouret martinbedouret linked an issue Dec 8, 2020 that may be closed by this pull request
Shared boards have some titles of symbols translated back to English #794
Closed
sylvansson
sylvansson approved these changes Dec 10, 2020
View reviewed changes
Copy link
Collaborator

@sylvansson sylvansson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not able to test locally at the moment, but I'll give it a try once deployed. LGTM.

src/components/Board/Board.container.js
showNotification(intl.formatMessage(messages.boardCopiedSuccessfully));
};

async createBoarsRecursively(board) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hehehe

@martinbedouret martinbedouret merged commit f6cd121 into master Dec 11, 2020
@martinbedouret martinbedouret deleted the fix/board-lang branch December 11, 2020 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sylvansson sylvansson sylvansson approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.7.1
Development

Successfully merging this pull request may close these issues.

Shared boards have some titles of symbols translated back to English
2 participants
@martinbedouret @sylvansson