feat: recursively merge file and group level values #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces an enhancement to the
mergeValuesfunction in Structuresmith, focusing on how it handles merging of nested structures, particularly slices. Previously, when merging two maps, slices within these maps were appended, which could lead to unintended duplication of data. With this update, slices in the source map now overwrite corresponding slices in the destination map, ensuring more predictable and clear outcomes when merging complex, nested configurations.This change is crucial for scenarios where template configurations involve arrays or lists that require a clean slate rather than an accumulation of values. This PR includes updated unit tests to validate this new behavior, ensuring that it handles various complex structures, including deeply nested maps and slices.