Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Element to Cell #82

Merged
merged 8 commits into from
Nov 5, 2023
Merged

Rename Element to Cell #82

merged 8 commits into from
Nov 5, 2023

Conversation

cbritopacheco
Copy link
Owner

No description provided.

@github-actions github-actions bot added geometry Rodin::Geometry variational Rodin::Variational mmg Rodin::External::MMG examples Examples io Rodin::IO labels Nov 4, 2023
@cbritopacheco cbritopacheco changed the title Develop Rename Element to Cell Nov 4, 2023
@github-actions github-actions bot added the unit-tests Unit tests label Nov 4, 2023
Copy link

codecov bot commented Nov 4, 2023

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (35d38ff) 37.98% compared to head (b371110) 40.40%.
Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
+ Coverage   37.98%   40.40%   +2.42%     
==========================================
  Files         116      114       -2     
  Lines        5597     5286     -311     
  Branches      442      432      -10     
==========================================
+ Hits         2126     2136      +10     
+ Misses       3381     3061     -320     
+ Partials       90       89       -1     
Files Coverage Δ
src/Rodin/Geometry/Mesh.h 53.48% <100.00%> (ø)
src/Rodin/Geometry/PolytopeIterator.h 52.94% <ø> (ø)
src/Rodin/Variational/FiniteElement.h 100.00% <100.00%> (ø)
src/Rodin/Variational/P1/P1.h 91.89% <ø> (ø)
src/Rodin/Variational/P1/P1Element.h 97.05% <100.00%> (+0.33%) ⬆️
src/Rodin/Variational/ShapeFunction.h 87.09% <ø> (ø)
tests/unit/Rodin/Geometry/MeshTest.cpp 98.18% <ø> (ø)
tests/unit/Rodin/Geometry/UniformGridTest.cpp 100.00% <ø> (ø)
tests/unit/Rodin/IO/MeshLoaderTest.cpp 100.00% <ø> (ø)
src/Rodin/Geometry/PolytopeIterator.cpp 62.37% <85.71%> (ø)
... and 7 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cbritopacheco cbritopacheco merged commit ef329c0 into master Nov 5, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Examples geometry Rodin::Geometry io Rodin::IO mmg Rodin::External::MMG unit-tests Unit tests variational Rodin::Variational
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant