tests/blockchain: duplicate INCORRECT_UPSTREAM_TESTS for ConstantinopleFix #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tation had error. Previously, "nested" computations would be recursed into even if they had an error; whereas "origin" computation would be recursed into on success only. This commit effectively makes so that "nested" comp-ns will be recursed into only if they are successful (that is, same logic as for "origin" comp-n). The rest of the changes are comments, heredoc brush-ups, and similar fluff from the debugging session.
|
Branch to inspect (hopefully) green checkbox: https://github.com/veox/py-evm/commits/pr-1719-petersborg-updated%2Bfix |
|
One test marked |
cburgdorf
force-pushed
the
christoph/feat/petersburg-fork
branch
3 times, most recently
from
08726b6
to
92b6585
Compare
|
Closing since cherry-picked into upstream PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For: ethereum#1719 (comment)
What was wrong?
Tests in
INCORRECT_UPSTREAM_TESTSare for Byzantium/Constantinople only.(See ethereum#1224 (comment) for a reminder of what's the actual issue with the tests, and further in that PR's discussion on why
I_U_Twas added.)How was it fixed?
subj.Cute Animal Picture
Source: Valdemaras @ efoto