-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
example: two crashed examples #248
Conversation
Thanks; if you could add a line to the doc/release_notes.txt file, and another retroactively for your previous #236? |
Thanks! I'm thinking that the 2D and 3D corner examples have much code in common. Do you think you could eliminate the 3.c file to the usual 2-liner we use in the library files and work with |
OK. Will do. |
Thanks; please note that I have pushed a small update to this branch in the meantime. |
example/balance/balance_corner2.c
Outdated
p4est = p8est_new_ext (mpi->mpicomm, connectivity, 15, 0, 0, | ||
sizeof (user_data_t), init_fn, geom); | ||
#endif | ||
p4est_vtk_write_file (p4est, geom, "test"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may consistently produce output with file names, after calling the respective algorithms, like
P4EST_STRING "_corner_new",
P4EST_STRING "_corner_refine",
P4EST_STRING "_corner_balance",
which will allow us to write the VTK outside the dimension #ifdefs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleted. The statement serves a test on the p4-to-p8 functionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind writing a VTK after new, after refine, after balance, and after partition.
With the name convention as above, this should all work without conflict:
with P4EST_STRING, the vtk_write_file function can be called outside the #ifdef.
Thanks, I have pushed on top as discussed in our video meeting. |
add two crashed examples in balance
Following up on issue #238 .
Proposed changes: