Feature boundary coordinates #334
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, coordinates were treated like from the lower left corner of a quadrant. Thus, they were not allowed to touch any high face of the unit tree. We change this to make coordinates valid on all tree boundaries. We also allow coordinates as deep as P4EST_MAXLEVEL (quadrant midpoints). The idea is to use the coordinates to index any boundary object of a quadrant, thus any of its corners and face, edge, and volume midpoints.
We had relaxed the requirements on p4est_coordinates_is_valid, thus when reading a quadrant from a file, use the specific function to verify it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for coordinates on all tree boundaries
Proposed changes
Previously, coordinates were treated like from the lower left corner of a quadrant. Thus, they were not allowed to touch any high face of the unit tree. We change this to make coordinates valid on all tree boundaries. We also allow coordinates as deep as P4EST_MAXLEVEL (quadrant midpoints).
The idea is to use the coordinates to index any boundary object of a quadrant, thus any of its corners and face, edge, and volume midpoints.
This may affect use of the coordinates outside of p4est. Any comments @tisaac?