thor support (#177)

src/scida/helpers_hdf5.py

@@ -217,8 +217,9 @@ def dtps(k, s):
         # create groups
         for group in sorted(groups):
             if group == "/":
-                continue  # nothing to do.
-            hf.create_group(group)
+                group = ""
+            else:
+                hf.create_group(group)
             groupfields = [
                 field
                 for field in shapes.keys()

tests/customs/test_all.py

@@ -11,6 +11,9 @@ def test_allunitsdiscovered(testdatapath, caplog):
     if "gaia" in testdatapath:
         # skip gaia for now; because invalid pint units (like mag) are not yet handled
         return
+    if "thor" in testdatapath:
+        # no metadata units in thor yet
+        return
     assert (
         "Cannot determine units from neither unit file nor metadata" not in caplog.text
     )

tests/customs/test_thor.py

@@ -0,0 +1,12 @@
+from scida.convenience import load
+from scida.interface import Dataset
+from tests.testdata_properties import require_testdata_path
+
+
+# for now we do individual photon types (original, peel, input) separately
+@require_testdata_path("interface", only=["thor_mcrt/peel"])
+def test_mcrt(testdatapath):
+    ds = load(testdatapath)
+    assert isinstance(ds, Dataset)
+    assert len(ds.data.keys()) > 0
+    print(ds.data.keys())

tests/test_discovery.py

@@ -26,7 +26,9 @@ def return_intended_stype(name) -> Type[DatasetSeries]:
         return SwiftSimulation
     elif any(k in name for k in ["tng"]):
         return ArepoSimulation
-    raise ValueError("Have not specified intended type for %s" % name)
+    print("No intended type found for %s" % name)
+    return DatasetSeries
+    # raise ValueError("Have not specified intended type for %s" % name)
 
 
 def return_intended_dstype(name, simconf=False) -> Type[Dataset]:
@@ -63,7 +65,9 @@ def return_intended_dstype(name, simconf=False) -> Type[Dataset]:
     elif any(k in name for k in ["rockstar"]):
         return RockstarCatalog
 
-    raise ValueError("Have not specified intended type for %s" % name)
+    print("No intended type found for %s" % name)
+    return Dataset
+    # raise ValueError("Have not specified intended type for %s" % name)
 
 
 @require_testdata_path("series")

tests/testdata.yaml

@@ -1,4 +1,7 @@
 testdata:
+  thor_mcrt/peel:
+    types:
+      - interface
   TNG50-4:
     types:
       - series