Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filename in Tutorial->simulations #98

Closed
EGaraldi opened this issue Dec 4, 2023 · 4 comments
Closed

Filename in Tutorial->simulations #98

EGaraldi opened this issue Dec 4, 2023 · 4 comments

Comments

@EGaraldi
Copy link

EGaraldi commented Dec 4, 2023

The code snippet and sample outputs in the simulation tutorial do not match the one obtained following the link provided in the same page. The former is "TNG50-4_snapshot" while the latter is "snapdir_030". Similarly, the content of the file is slightly different than showed in the tutorial page. If possible, homogenize them for clarity.

@dnelson86
Copy link
Collaborator

I suggest to drop non-standard names like "TNG50-4_snapshot" completely.

Let's stick to the data formats, and organization, of the large data sets, as they are available.

(If this means that e.g. any automatic testing based on such snapshots must run with access to /virgotng/ or similar, I think this is ok).

@kyleaoman
Copy link

Just to be specific, the "GFM_AGNRadiation" field mentioned in the tutorial doesn't exist in the example file.

@kyleaoman
Copy link

Likewise the projection image from the example file differs a bit from the one in the documentation.

cbyrohl added a commit that referenced this issue Jan 2, 2024
@cbyrohl
Copy link
Owner

cbyrohl commented Jan 2, 2024

Thanks @EGaraldi, non standard name dropped in favor of folder name "snapdir_030" in #126 . Thanks @kyleaoman, field reference and projection image adjusted in #114

@cbyrohl cbyrohl closed this as completed in 2d4c4cb Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants