Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add LocalSubhaloID and SubhaloID field #71

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Conversation

cbyrohl
Copy link
Owner

@cbyrohl cbyrohl commented Aug 9, 2023

For Arepo snapshots with FoF+Subfind data, introduce more mapped per-particle fields.

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Patch coverage: 53.84% and project coverage change: +0.75% 🎉

Comparison is base (206ad97) 56.08% compared to head (de89d15) 56.84%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
+ Coverage   56.08%   56.84%   +0.75%     
==========================================
  Files          53       53              
  Lines        4711     4729      +18     
  Branches      938      942       +4     
==========================================
+ Hits         2642     2688      +46     
+ Misses       1870     1839      -31     
- Partials      199      202       +3     
Files Changed Coverage Δ
tests/test_fields.py 25.97% <0.00%> (ø)
src/scida/customs/arepo/dataset.py 35.12% <56.00%> (+2.00%) ⬆️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cbyrohl cbyrohl merged commit 4141a9e into main Aug 9, 2023
4 of 5 checks passed
@cbyrohl cbyrohl deleted the ModifySubhaloIDbehavior branch August 9, 2023 19:30
@cbyrohl cbyrohl restored the ModifySubhaloIDbehavior branch August 11, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant