Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding test / add missing dataset attribute #80

Merged
merged 6 commits into from
Aug 11, 2023
Merged

Conversation

cbyrohl
Copy link
Owner

@cbyrohl cbyrohl commented Aug 11, 2023

No description provided.

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Patch coverage: 43.33% and project coverage change: -0.05% ⚠️

Comparison is base (dff12f4) 56.63% compared to head (32af595) 56.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
- Coverage   56.63%   56.58%   -0.05%     
==========================================
  Files          51       52       +1     
  Lines        4815     4835      +20     
  Branches      959      961       +2     
==========================================
+ Hits         2727     2736       +9     
- Misses       1879     1890      +11     
  Partials      209      209              
Files Changed Coverage Δ
tests/simulations/test_tngcatalog_operations.py 33.33% <33.33%> (ø)
src/scida/customs/arepo/dataset.py 34.36% <50.00%> (+0.35%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cbyrohl cbyrohl merged commit 9e148e0 into main Aug 11, 2023
3 of 5 checks passed
@cbyrohl cbyrohl deleted the ModifySubhaloIDbehavior branch August 18, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant