Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue24 #81

Merged
merged 14 commits into from
Aug 18, 2023
Merged

Issue24 #81

merged 14 commits into from
Aug 18, 2023

Conversation

cbyrohl
Copy link
Owner

@cbyrohl cbyrohl commented Aug 11, 2023

fixes issue #24

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Patch coverage: 72.22% and project coverage change: +0.26% 🎉

Comparison is base (df5faa2) 54.77% compared to head (38f0ba1) 55.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
+ Coverage   54.77%   55.04%   +0.26%     
==========================================
  Files          56       56              
  Lines        5371     5425      +54     
  Branches     1061     1070       +9     
==========================================
+ Hits         2942     2986      +44     
- Misses       2206     2212       +6     
- Partials      223      227       +4     
Files Changed Coverage Δ
tests/test_docs.py 96.36% <0.00%> (ø)
src/scida/config.py 77.09% <66.00%> (-1.40%) ⬇️
src/scida/misc.py 64.23% <66.66%> (+0.72%) ⬆️
src/scida/convenience.py 51.15% <100.00%> (+0.22%) ⬆️
src/scida/interfaces/mixins/units.py 72.59% <100.00%> (ø)
tests/test_config.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cbyrohl
Copy link
Owner Author

cbyrohl commented Aug 11, 2023

Still missing documentation for unitfiles and simulations.yaml

@cbyrohl cbyrohl merged commit 97797e6 into main Aug 18, 2023
5 checks passed
@cbyrohl cbyrohl deleted the issue24 branch August 23, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant