Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix idxlist arg + start adding shID slct #82

Merged
merged 5 commits into from
Aug 12, 2023
Merged

fix idxlist arg + start adding shID slct #82

merged 5 commits into from
Aug 12, 2023

Conversation

cbyrohl
Copy link
Owner

@cbyrohl cbyrohl commented Aug 11, 2023

Fixes #29

@codecov
Copy link

codecov bot commented Aug 12, 2023

Codecov Report

Patch coverage: 10.65% and project coverage change: -1.50% ⚠️

Comparison is base (9e148e0) 56.72% compared to head (578264e) 55.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
- Coverage   56.72%   55.22%   -1.50%     
==========================================
  Files          54       52       -2     
  Lines        4850     4978     +128     
  Branches      961      986      +25     
==========================================
- Hits         2751     2749       -2     
- Misses       1890     2020     +130     
  Partials      209      209              
Files Changed Coverage Δ
tests/customs/test_arepo.py 12.05% <8.69%> (-2.58%) ⬇️
src/scida/customs/arepo/dataset.py 31.51% <11.71%> (-2.85%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cbyrohl cbyrohl merged commit 1564cb7 into main Aug 12, 2023
2 of 5 checks passed
@cbyrohl cbyrohl deleted the issue29 branch August 18, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grouping and reduction operation on subhalos
1 participant