Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For grouped operations, handle empty inputs/returns #83

Merged
merged 6 commits into from
Aug 14, 2023
Merged

Conversation

cbyrohl
Copy link
Owner

@cbyrohl cbyrohl commented Aug 12, 2023

Fixes a recent problem from #62

@codecov
Copy link

codecov bot commented Aug 12, 2023

Codecov Report

Patch coverage: 9.82% and project coverage change: -0.58% ⚠️

Comparison is base (d6f923d) 55.22% compared to head (cb29161) 54.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
- Coverage   55.22%   54.64%   -0.58%     
==========================================
  Files          52       54       +2     
  Lines        4978     5071      +93     
  Branches      986     1003      +17     
==========================================
+ Hits         2749     2771      +22     
- Misses       2020     2091      +71     
  Partials      209      209              
Files Changed Coverage Δ
src/scida/customs/arepo/dataset.py 30.03% <4.54%> (-1.48%) ⬇️
tests/customs/test_arepo.py 11.30% <14.63%> (-0.75%) ⬇️
src/scida/helpers_misc.py 54.54% <40.00%> (-1.20%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cbyrohl cbyrohl merged commit eabde75 into main Aug 14, 2023
2 of 5 checks passed
@cbyrohl cbyrohl deleted the issue62 branch August 18, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant