Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more units #96

Merged
merged 2 commits into from
Sep 15, 2023
Merged

more units #96

merged 2 commits into from
Sep 15, 2023

Conversation

cbyrohl
Copy link
Owner

@cbyrohl cbyrohl commented Sep 15, 2023

No description provided.

@cbyrohl cbyrohl merged commit df3be34 into main Sep 15, 2023
3 checks passed
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage: 84.37% and project coverage change: +0.26% 🎉

Comparison is base (29d1b3a) 54.65% compared to head (44d06f5) 54.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
+ Coverage   54.65%   54.91%   +0.26%     
==========================================
  Files          63       65       +2     
  Lines        5621     5645      +24     
  Branches     1103     1105       +2     
==========================================
+ Hits         3072     3100      +28     
+ Misses       2317     2314       -3     
+ Partials      232      231       -1     
Files Changed Coverage Δ
src/scida/misc.py 64.23% <0.00%> (ø)
src/scida/interfaces/mixins/units.py 72.79% <60.00%> (-0.43%) ⬇️
tests/customs/test_auriga.py 71.42% <71.42%> (ø)
src/scida/customs/arepo/dataset.py 31.25% <100.00%> (ø)
src/scida/customs/gizmo/dataset.py 91.66% <100.00%> (+0.17%) ⬆️
tests/customs/test_all.py 100.00% <100.00%> (ø)
tests/test_config.py 100.00% <100.00%> (ø)
tests/test_issues.py 75.55% <100.00%> (+3.05%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cbyrohl cbyrohl mentioned this pull request Sep 15, 2023
12 tasks
@cbyrohl cbyrohl deleted the BetterUnitSupport branch February 29, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant