Skip to content
This repository has been archived by the owner on Apr 25, 2024. It is now read-only.

Deprecate vocabulary #11

Merged
merged 19 commits into from
Jan 25, 2022
Merged

Conversation

MuluhGodson
Copy link
Contributor

Fixes

Fixes #10 by @brylie

Description

This PR deprecates vocabulary and replaces it with:

  • cc-assets
  • vocabulary-styles
  • vocabulary-fonts

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@MuluhGodson MuluhGodson added the 💻 aspect: code Concerns the software code in the repository label Jan 24, 2022
Copy link
Contributor

@brylie brylie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's avoid declaring dependencies we don't use. Double-check the FontAwesome dependencies and remove any that are unneeded.

@MuluhGodson MuluhGodson requested a review from brylie January 25, 2022 08:06
@brylie brylie merged commit 9250165 into cc-archive:main Jan 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository
Development

Successfully merging this pull request may close these issues.

Remove dependency on Vocabulary package
2 participants