Cache pages builds #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfsnow
commented
Dec 3, 2024
| @@ -31,12 +38,14 @@ jobs: | |||
| run: uv pip install .[docs] | |||
|
|
|||
| - name: Generate HTML | |||
| run: uv run sphinx-build -d _build/doctrees docs/source _build/html | |||
| run: | | |||
There was a problem hiding this comment.
I also set the -j auto flag here to take advantage of parallel building within Sphinx.
jeancochrane
approved these changes
Dec 3, 2024
| @@ -14,3 +14,4 @@ | |||
| nb_render_image_options = {"width": "450px", "align": "center"} | |||
| nb_execution_timeout = 600 | |||
| html_sidebars = {"**": []} | |||
| jupyter_execute_notebooks = "cache" | |||
There was a problem hiding this comment.
[Question, non-blocking] Can you point me to docs for this config option? I assumed it would be in the jupyter-sphinx docs but I couldn't find anything there.
There was a problem hiding this comment.
It's part of the Myst NB config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds caching for our pages build, since it takes awhile and currently runs on every PR commit. I couldn't get sphinx caching to work (it seems to somehow rely on the modified time of files), but caching the jupyter notebook build works fine and brings the build from ~3 minutes to <20 seconds.