Bring dbt setup instructions up to date #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeancochrane
force-pushed
the
jeancochrane/update-dbt-setup-instructions
branch
from
e7ecb64 to
9bf4baa
Compare
jeancochrane
commented
Nov 22, 2023
| @@ -128,6 +128,7 @@ Run the following commands in this directory: | |||
| ``` | |||
| python3 -m venv venv | |||
| source venv/bin/activate | |||
| pip install -U pip | |||
There was a problem hiding this comment.
Older versions of pip are subject to a known bug that prevents packages from installing correctly:
$ pip install -r requirements.txt
...
ERROR: Exception:
Traceback (most recent call last):
File "/home/jecochr/code/data-architecture/dbt/new-venv/lib/python3.10/site-packages/pip/_internal/cli/base_command.py", line 165, in exc_logging_wrapper
status = run_func(*args)
File "/home/jecochr/code/data-architecture/dbt/new-venv/lib/python3.10/site-packages/pip/_internal/cli/req_command.py", line 205, in wrapper
return func(self, options, args)
File "/home/jecochr/code/data-architecture/dbt/new-venv/lib/python3.10/site-packages/pip/_internal/commands/install.py", line 389, in run
to_install = resolver.get_installation_order(requirement_set)
File "/home/jecochr/code/data-architecture/dbt/new-venv/lib/python3.10/site-packages/pip/_internal/resolution/resolvelib/resolver.py", line 188, in get_installation_order
weights = get_topological_weights(
File "/home/jecochr/code/data-architecture/dbt/new-venv/lib/python3.10/site-packages/pip/_internal/resolution/resolvelib/resolver.py", line 276, in get_topological_weights
assert len(weights) == expected_node_count
AssertionError
Making sure pip is up to date with the latest version in the virtualenv resolves this bug.
| @@ -256,13 +257,13 @@ dbt test --select default.vw_pin_universe | |||
| Run only one test: | |||
|
|
|||
| ``` | |||
| dbt test --select vw_pin_universe_unique_by_14_digit_pin_and_year | |||
| dbt test --select default_vw_pin_universe_unique_by_14_digit_pin_and_year | |||
There was a problem hiding this comment.
This test got renamed in #236.
dfsnow
approved these changes
Nov 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While pairing on dbt setup with Damon, I noticed a couple of outdated sections in the README. This PR tweaks those sections so that the setup instructions work as written.