Add expression_is_false dbt test macro
#464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is ready to go, though these test names feel backwards to me. Probably not important. |
jeancochrane
approved these changes
May 21, 2024
There was a problem hiding this comment.
Nice! Real quick before we merge this in, could we add some simple docs for expression_is_false to the generic tests README?
Comment on lines
+9
to
+27
| {% test expression_is_false( | ||
| model, column_name, expression, additional_select_columns=[] | ||
| ) %} | ||
| {%- set select_columns_csv = format_additional_select_columns( | ||
| additional_select_columns | ||
| ) -%} | ||
| {%- if column_name -%} | ||
| {%- set columns_csv = column_name -%} | ||
| {%- if select_columns_csv -%} | ||
| {%- set columns_csv = columns_csv ~ ", " ~ select_columns_csv -%} | ||
| {%- endif -%} | ||
| {%- elif select_columns_csv -%} {%- set columns_csv = select_columns_csv -%} | ||
| {%- else -%} {%- set columns_csv = "1 AS fail" -%} | ||
| {%- endif -%} | ||
|
|
||
| select {{ columns_csv }} | ||
| from {{ model }} | ||
| where ({{ column_name }} {{ expression }}) | ||
| {% endtest %} |
There was a problem hiding this comment.
[Thought, non-blocking] Looks like everything here is identical to expression_is_true except for the lack of a not operator on line 26. Perhaps a sign that we could factor out the shared logic into a third macro that expression_is_true and expression_is_false both depend on? Not required by any means, but something to think about!
There was a problem hiding this comment.
I'm not opposed to that at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current
expression_is_truedbt tests can lead to some weird backwards engineering trying to figure out how to invert logic given how it employsNOTbefore theWHEREclause it tests. Having an alternative to avoid these situations would be helpful.