Further improvements to dbt sort order linter #647
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#644 got merged in before we could implement two pieces of feedback:
exclude
attribute of the pre-commit hook to be more precise and only exclude files in a directory matching the stringvenv/
rather than any file containing the substringvenv
, which could exist without being in a venv dir (comment)In the course of implementing these two pieces of feedback, I also noticed that the logic to check for properly sorted tests is only looking at data tests and so is ignoring the unit tests we added in #638. This PR also tweaks that logic so that we are properly linting unit tests.
Sample output including both types of unsorted tests: