-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update training/input data #41
Conversation
@@ -395,4 +395,4 @@ ratio_study: | |||
# upload | |||
export: | |||
triad_code: "1" | |||
run_id: "2024-02-16-silly-billy" | |||
run_id: "2024-03-11-pensive-manasi" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the new final run ID w SHAPs.
@@ -283,7 +283,7 @@ | |||
"RemoteUsername": "ccao-data", | |||
"RemoteRepo": "ccao", | |||
"RemoteRef": "master", | |||
"RemoteSha": "6bdb2f2cab811c3450d91726a784804bd8bca971", | |||
"RemoteSha": "fe992f9bb6e75c97a0c8fa742106096adbabb642", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just updating the CCAO package to the latest version. It's tangential to this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I didn't take a look at the rendered desk review sheets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some serious duct tape in this one, but I think it's probably the best option if we really can't run another round of sales val.
The workbook looks good too, let's just make sure to correct the number formatting on the Average YoY ∆ %
column in the Neighborhood Breakout
sheet to a percentage with 1 decimal point before we share the workbooks:
model-condo-avm/pipeline/07-export.R
Lines 520 to 529 in f5870ca
### NOTE ### | |
# OpenXLSX is not perfect and messes up the macros and formatting on saved | |
# workbooks. To finish each workbook, you must manually: | |
# 1. Open the Neighborhood Breakout sheet and ensure that the values are | |
# all formatted correctly in the pivot table; if not (e.g. if | |
# `Average of YoY ∆ %` is formatted as a date when it should be a percentage) | |
# then manually update the formatting by selecting | |
# PivotTable Fields > Values > {fieldname} > Value Field Settings... > | |
# Number Format. |
This PR fixes the missing sales situation discovered in ccao-data/data-architecture#334. It:
sv_added_later
)