Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mouse wheel shortcuts akin to plasma's media player widget #115

Closed
AuraHerreroRuiz opened this issue Jul 21, 2024 · 6 comments · Fixed by #117
Closed

Mouse wheel shortcuts akin to plasma's media player widget #115

AuraHerreroRuiz opened this issue Jul 21, 2024 · 6 comments · Fixed by #117

Comments

@AuraHerreroRuiz
Copy link

Something I'd like to see for this plasmoid is to add the actions the normal media player plasmoid has: Increase and decrease the current player's volume using the scroll wheel, and pause/resume on middle click.

luisbocanegra added a commit to luisbocanegra/plasmusic-toolbar that referenced this issue Jul 22, 2024
luisbocanegra added a commit to luisbocanegra/plasmusic-toolbar that referenced this issue Jul 22, 2024
Also go previous/next with back/forward mouse buttons

Closes: ccatterina#115
luisbocanegra added a commit to luisbocanegra/plasmusic-toolbar that referenced this issue Jul 22, 2024
Also go previous/next with back/forward mouse buttons
Allow to scroll the volume var to adjust volume

Closes: ccatterina#115
luisbocanegra added a commit to luisbocanegra/plasmusic-toolbar that referenced this issue Jul 22, 2024
Also go previous/next with back/forward mouse buttons
Allow to scroll the volume bar to adjust volume

Closes: ccatterina#115
@luisbocanegra
Copy link
Contributor

luisbocanegra commented Jul 22, 2024

Added in #117, please test it out

Update from the current version

git clone https://github.com/luisbocanegra/plasmusic-toolbar.git -b mouse-wheel-controls
cd plasmusic-toolbar && kpackagetool6 -t Plasma/Applet -u src

Then logout/reboot/restart plasmashell

Screenshot_20240721_194441

Should the step size be configurable? I left it fixed to 5%

luisbocanegra added a commit to luisbocanegra/plasmusic-toolbar that referenced this issue Jul 22, 2024
Also go previous/next with back/forward mouse buttons
Allow to scroll the volume bar to adjust volume

Closes: ccatterina#115
@AuraHerreroRuiz
Copy link
Author

AuraHerreroRuiz commented Jul 22, 2024

Added in #117, please test it out

Works perfectly! Thanks a lot for adding it.

Should the step size be configurable? I left it fixed to 5%

Hmm, from what I can tell, Plasma's default mediaplayer widget follows the volume step size specified in settings, just like the volume widget. (Input & Output > Sound > Configure Volume Controls...)
22-07_14-18_0001

I feel it should follow that, if possible, for consistency with the rest of plasma.

luisbocanegra added a commit to luisbocanegra/plasmusic-toolbar that referenced this issue Jul 22, 2024
Also go previous/next with back/forward mouse buttons
Allow to scroll the volume bar to adjust volume

Closes: ccatterina#115
@luisbocanegra
Copy link
Contributor

Hmm, from what I can tell, Plasma's default mediaplayer widget follows the volume step size specified in settings, just like the volume widget. (Input & Output > Sound > Configure Volume Controls...)

Added, the cpp plugin from the default media player provides that https://github.com/KDE/plasma-workspace/tree/master/applets/mediacontroller/plugin (import org.kde.plasma.private.mediacontroller 1.0)

In theory, the default media player widget should always be shipped with Plasma, but since it is no longer a hard requirement to have working media shortcuts after MR applets/mediacontroller: port away from DataEngine (BUG 409190) I will add a conditional import and fallback to 5 if the module can't be imported.

luisbocanegra added a commit to luisbocanegra/plasmusic-toolbar that referenced this issue Jul 22, 2024
Also go previous/next with back/forward mouse buttons
Allow to scroll the volume bar to adjust volume

Closes: ccatterina#115
luisbocanegra added a commit to luisbocanegra/plasmusic-toolbar that referenced this issue Jul 24, 2024
Also go previous/next with back/forward mouse buttons
Allow to scroll the volume bar to adjust volume

Closes: ccatterina#115
@ccatterina
Copy link
Owner

Added, the cpp plugin from the default media player provides that https://github.com/KDE/plasma-workspace/tree/master/applets/mediacontroller/plugin (import org.kde.plasma.private.mediacontroller 1.0)

In theory, the default media player widget should always be shipped with Plasma, but since it is no longer a hard requirement to have working media shortcuts after MR applets/mediacontroller: port away from DataEngine (BUG 409190) I will add a conditional import and fallback to 5 if the module can't be imported.

@luisbocanegra @AuraHerreroRuiz
I'm not very sure if it's worth doing this; I would prefer not to couple this widget too much with the media controller. For now, IMO it can remain a non-configurable value but if you guys prefer to make it configurarable we can add a new option in the settings.

luisbocanegra added a commit to luisbocanegra/plasmusic-toolbar that referenced this issue Jul 27, 2024
Also go previous/next with back/forward mouse buttons
Allow to scroll the volume bar to adjust volume

Closes: ccatterina#115
@luisbocanegra
Copy link
Contributor

I'm not very sure if it's worth doing this; I would prefer not to couple this widget too much with the media controller.

Understandable, reverted it back to 5%.

For now, IMO it can remain a non-configurable value but if you guys prefer to make it configurarable we can add a new option in the settings.

Personally, I never change the default on Plasma either, but for the people that do, an option that allows them to manually match the rest of the system could be nice IMHO.

luisbocanegra added a commit to luisbocanegra/plasmusic-toolbar that referenced this issue Jul 28, 2024
Also go previous/next with back/forward mouse buttons
Allow to scroll the volume bar to adjust volume

Closes: ccatterina#115
@ccatterina
Copy link
Owner

Personally, I never change the default on Plasma either, but for the people that do, an option that allows them to manually match the rest of the system could be nice IMHO.

👍 it's fine for me!

luisbocanegra added a commit to luisbocanegra/plasmusic-toolbar that referenced this issue Jul 28, 2024
Also go previous/next with back/forward mouse buttons
Allow to scroll the volume bar to adjust volume

Closes: ccatterina#115
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants