Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build a simple google translate example around simple_report.py (NO_J… #70

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

jasonccole
Copy link
Contributor

…IRA)

This little example builds on simple_report.py - shows how to modify it to translate the report into another language

@jasonccole jasonccole requested a review from Alex-AMC November 13, 2024 14:44
Copy link
Contributor

@Alex-AMC Alex-AMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very useful!

Some minor things in the PR but looks good to me :)

Copy link
Contributor

@Alex-AMC Alex-AMC Nov 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please remove the output of all the cells ( I think the last one in particular is a bit too big) Cell 3 less so.

A suggestion and not necessary - I can see that you've added the dependencies as googletrans, might be nice to have a cell that installs it using magic commands

!conda install googletrans 
or 
!pip install googletrans 

That way, the user doesn't have to leave the notebook :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did try that but for me it proved somewhat problematic (basically just failed)

@jasonccole jasonccole merged commit f041769 into main Nov 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants