Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.1] add CI tests + new strain energy calculations and data for plots #2

Merged
merged 14 commits into from
Jan 30, 2024

Conversation

cch1999
Copy link
Owner

@cch1999 cch1999 commented Jan 18, 2024

No description provided.

@cch1999
Copy link
Owner Author

cch1999 commented Jan 30, 2024

[Version 1.1] - 30-01-2024

Changed

  • [IMPORTANT - PLEASE READ IF YOU INTEND TO PUBLISH] Changed the way strain energy is calculated. Previously, the strain energy was calculated as the difference between the energy of the raw output and a fully relaxed structure. This meant that the energy term of the raw output exploded due to slight imperfections in local bond lengths and angles and did not reflect global strain well. Now we perform a small bit of local relaxation (max displacement in the atom positions of 0.1 Å) and use the energy of this structure as the reference energy. This means that the strain energy is now a more accurate reflection of the global strain of the molecule.

Added

  • Data and notebooks needed to reproduce plots from the paper.
  • Validator that warms the user if reduce cannot be found.
  • CI tests
  • Full environment specs

Fixed

  • Improved doc string coverage

@cch1999 cch1999 merged commit 049301f into main Jan 30, 2024
4 checks passed
@cch1999 cch1999 deleted the new_strain branch August 21, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant