Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend: Allow gnomad fields to display as empty if missing #405

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

frewmack
Copy link
Contributor

@frewmack frewmack commented Jun 4, 2024

Closes #355

Some variants will still show gnomadHom even if the annotation is missing. This is because the gnomadHom field was retrieved by the query to Phenotips itself, and wasn't overridden by the annotation step in OSMP.

@frewmack frewmack merged commit 7d0094d into develop Jun 4, 2024
2 checks passed
@frewmack frewmack deleted the mack/hide-missing-gnomad branch June 4, 2024 14:50
frewmack added a commit that referenced this pull request Jun 17, 2024
* Bump mysql2 from 3.9.7 to 3.9.8 in /test-node (#404)

Bumps [mysql2](https://github.com/sidorares/node-mysql2) from 3.9.7 to 3.9.8.
- [Release notes](https://github.com/sidorares/node-mysql2/releases)
- [Changelog](https://github.com/sidorares/node-mysql2/blob/master/Changelog.md)
- [Commits](sidorares/node-mysql2@v3.9.7...v3.9.8)

---
updated-dependencies:
- dependency-name: mysql2
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Allow gnomad fields to display as empty if missing (#405)

* Replace set-output the correct way (?) (#406)

* Trim newlines from ssh agent eval string (#407)

* Bump braces from 3.0.2 to 3.0.3 in /server (#408)

Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3.
- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md)
- [Commits](micromatch/braces@3.0.2...3.0.3)

---
updated-dependencies:
- dependency-name: braces
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frontend: hide Gnomad fields from variants where gnomad annotations were not found
1 participant