Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stiebeleltron dashboard using old datasource variables #115

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Fix stiebeleltron dashboard using old datasource variables #115

merged 1 commit into from
Jan 10, 2022

Conversation

ccremer
Copy link
Owner

@ccremer ccremer commented Jan 10, 2022 •
edited
Loading

What this PR does / why we need it:

  • Removes settings that made the dashboard "sharable externally", which meant that the datasource, bucket and site variables couldn't be populated

Checklist

  • Chart Version bumped
  • make docs lint passes
  • Variables are documented in the values.yaml as required in Helm-Docs.
  • PR contains the label that identifies the chart, e.g. chart/[chart]
  • PR contains the label that identifies the type of change, which is one of
    bug, enhancement, documentation, change, breaking, dependency

@ccremer ccremer added bug Something isn't working chart/stiebeleltron-stack labels Jan 10, 2022
@ccremer ccremer merged commit e1b6e65 into master Jan 10, 2022
@ccremer ccremer deleted the fix-se-dashboard branch January 10, 2022 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working chart/stiebeleltron-stack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ccremer