add v4l2rtspserver v4l2tools v4l2cpp packages #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccrisan
reviewed
Oct 6, 2019
package/Config.in
Outdated
| @@ -7,6 +7,7 @@ menu "Target packages" | |||
| source "package/skeleton-init-none/Config.in" | |||
| source "package/skeleton-init-systemd/Config.in" | |||
| source "package/skeleton-init-sysv/Config.in" | |||
| source "package/motioneye/Config.in" | |||
There was a problem hiding this comment.
I don't think adding motioneye package here is a good idea, since motionEye is far from a regular BuildRoot package in motionEyeOS. It simply won't work on anything else than motionEyeOS.
ccrisan
reviewed
Oct 6, 2019
package/Config.in
Outdated
| @@ -952,6 +955,7 @@ menu "External python modules" | |||
| source "package/python-oauthlib/Config.in" | |||
| source "package/python-paho-mqtt/Config.in" | |||
| source "package/python-pam/Config.in" | |||
| source "package/python-pantilthat/Config.in" | |||
There was a problem hiding this comment.
This should have been added here, indeed, but I think it's missing the package folder.
|
My apologies for adding those packages unintentionally. That's the consequence of working until 1 o'clock in the morning. :-( I have reverted those changes. This PR is now purely adds the 3 v4l2 packages. |
This was referenced Oct 6, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just what the title says, add v4l2rtspserver v4l2tools v4l2cpp packages.