Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.8 support #642

Merged
merged 4 commits into from
Jun 30, 2023
Merged

Drop Python 3.8 support #642

merged 4 commits into from
Jun 30, 2023

Conversation

rjgildea
Copy link

Upstream dependencies (e.g. numpy, scipy) have now dropped Python 3.8 support in latest releases.

Add Python 3.11 support.

See also https://dials.github.io/kb/proposals/dc3

Upstream dependencies (e.g. numpy, scipy) have now dropped Python 3.8
support in latest releases.

Add Python 3.11 support.

See also https://dials.github.io/kb/proposals/dc3
@rjgildea rjgildea requested a review from ndevenish June 27, 2023 14:43
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #642 (652b524) into main (71d4ec0) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 652b524 differs from pull request most recent head f42b51b. Consider uploading reports for the commit f42b51b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #642      +/-   ##
==========================================
- Coverage   39.39%   39.39%   -0.01%     
==========================================
  Files         178      178              
  Lines       15496    15519      +23     
  Branches     2613     2996     +383     
==========================================
+ Hits         6104     6113       +9     
+ Misses       8832     8827       -5     
- Partials      560      579      +19     

@ndevenish
Copy link
Collaborator

This also seems to have the numpy warning issues, but not in a way that fails tests.

The only thing I'm unsure of is if it is worth doubling up the testing to both 3.9 and 3.11, but I guess all of the builds take less time than one DIALS build, so not too much of a problem.

@rjgildea
Copy link
Author

This also seems to have the numpy warning issues, but not in a way that fails tests.

We run pytest with PYTHONDEVMODE=1 which means we see DeprecationWarnings in the output, but that alone doesn’t cause tests to fail. Tests that call subprocess.run typically check for empty stderr which is what is causing the tests to fail. We could add filterwarnings in pytest.ini but that wouldn’t propagate to subprocesses.

@rjgildea
Copy link
Author

The only thing I'm unsure of is if it is worth doubling up the testing to both 3.9 and 3.11, but I guess all of the builds take less time than one DIALS build, so not too much of a problem.

Linux and Mac is already built/tested on 3.9 (as of this PR) and 3.11. Windows isn’t built for 3.11, but perhaps we should add that to for completeness?

@ndevenish
Copy link
Collaborator

Ah, yes I missed that it was just updating the two. Yeah, probably makes sense to do windows too - it was probably a legacy "windows build is complicated" reason not to

@rjgildea rjgildea merged commit 1625cfa into main Jun 30, 2023
@rjgildea rjgildea deleted the drop-py38 branch June 30, 2023 08:42
toastisme pushed a commit to toastisme/dxtbx that referenced this pull request Jul 18, 2024
Upstream dependencies (e.g. numpy, scipy) have now dropped Python 3.8
support in latest releases.

Add Python 3.11 support.

See also https://dials.github.io/kb/proposals/dc3

---------

Co-authored-by: Nicholas Devenish <ndevenish@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants