-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Python 3.8 support #642
Conversation
Upstream dependencies (e.g. numpy, scipy) have now dropped Python 3.8 support in latest releases. Add Python 3.11 support. See also https://dials.github.io/kb/proposals/dc3
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #642 +/- ##
==========================================
- Coverage 39.39% 39.39% -0.01%
==========================================
Files 178 178
Lines 15496 15519 +23
Branches 2613 2996 +383
==========================================
+ Hits 6104 6113 +9
+ Misses 8832 8827 -5
- Partials 560 579 +19 |
This also seems to have the numpy warning issues, but not in a way that fails tests. The only thing I'm unsure of is if it is worth doubling up the testing to both 3.9 and 3.11, but I guess all of the builds take less time than one DIALS build, so not too much of a problem. |
We run |
Linux and Mac is already built/tested on 3.9 (as of this PR) and 3.11. Windows isn’t built for 3.11, but perhaps we should add that to for completeness? |
Ah, yes I missed that it was just updating the two. Yeah, probably makes sense to do windows too - it was probably a legacy "windows build is complicated" reason not to |
Upstream dependencies (e.g. numpy, scipy) have now dropped Python 3.8 support in latest releases. Add Python 3.11 support. See also https://dials.github.io/kb/proposals/dc3 --------- Co-authored-by: Nicholas Devenish <ndevenish@gmail.com>
Upstream dependencies (e.g. numpy, scipy) have now dropped Python 3.8 support in latest releases.
Add Python 3.11 support.
See also https://dials.github.io/kb/proposals/dc3