Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sendrawtransaction broken for non-zero burn transactions in core 25.0 #181

Closed
BamaHodl opened this issue Jun 30, 2023 · 1 comment
Closed

sendrawtransaction broken for non-zero burn transactions in core 25.0 #181

BamaHodl opened this issue Jun 30, 2023 · 1 comment

Comments

@BamaHodl
Copy link
Contributor

Recently bitcoin core added an optional parameter to the sendrawtransaction call to limit intentional burns. It was implmented in this commit. This was released in Bitcoin Core 25.0.

Whereas there was no default limit prior to 25.0, the default is now set to 0, meaning sending non-zero values to OP_RETURN via sendrawtransaction will fail by default.

To keep pre-25.0 functionality intact, users of that RPC call (electrum servers, among others) will need to send the new maxburnamount parameter in the RPC call, which will also require sending the previously unset maxfeerate.
BamaHodl pushed a commit to BamaHodl/Fulcrum that referenced this issue Jun 30, 2023
issue cculianu#181 preserve pre-25.0 functionality for sendrawtransac…
d9ef13d 
…tion and fix one small typo (Vulberable)
cculianu pushed a commit that referenced this issue Sep 29, 2023
@BamaHodl
issue #181 preserve pre-25.0 functionality for sendrawtransaction and… (
c3ee3e5 
#182)

* issue #181 preserve pre-25.0 functionality for sendrawtransaction and fix one small typo (Vulberable)

* make BTC version check specific to BTC

---------

Co-authored-by: BamaHodl <BamaHodl@github.com>
@cculianu
Copy link
Owner

This has been fixed by #182

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cculianu @BamaHodl