SynchMempoolTask: Add parallel UTXO precacher for perf. benefit of up to ~30% + BugFix #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should work well enough, and should improve performance.
Hopefully this makes SynchMempool on pathological mempools faster.
This reverts commit f46bd75. It was no faster to use threads, and if anything, it ate up resources.
We download out-of-order so it's possible to dl a child txn while the parent txn drops out, and then we fail to find the coin for the parent. This caused very rare scripthash notification bugs on BTC and has now been fixed.
cculianu
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add a parallel UTXO precache mechanism to the
SynchMempoolTask. This mechanism looks UTXOs up in the utxodb as we are busy downloading mempool txns from bitcoind. The benefit is not large for small mempools but on e.g. BTC with ~140k txns in the mempool, the performance benefit is up to ~33% over existing code. This is because we utilize the disk and CPU concurrently with the network while downloading large mempools.Also in this PR:
SynchMempoolTaskinto its own compilation unit and header.SynchMempoolTaskwould attempt to add the child txns to the mempool but the parent would be missing, thus inputs would be missing, and this would lead to an exception being thrown and the mempool being left in a state where not all its data structures for the new txns would be filled-in, leading to observed behavior of scripthash notifications for the txns in question not being sent to clients.