Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker support #80

Merged
merged 5 commits into from
Sep 25, 2023
Merged

Docker support #80

merged 5 commits into from
Sep 25, 2023

Conversation

MyGodItsFull0fStars
Copy link
Collaborator

Added a Dockerfile to execute VCA from a Docker container.

This is done to ensure that systems that otherwise can't execute VCA are able to do so via Docker.

Copy link
Collaborator

@ChristianFeldmann ChristianFeldmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one tiny thing. Otherwise nice. Even more ways to use VCA on platforms where it may not compile natively.

.gitignore Outdated
.vscode
docs/build.md
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would you gitignoe that documentation flle?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I seem to have added it by accident. Thank you for pointing that out. Will change that. :)

@ChristianFeldmann
Copy link
Collaborator

I think we have to update the runners first (#81) before we can merge this.

@MyGodItsFull0fStars
Copy link
Collaborator Author

Apparently, these two OS variants failed for quite some time. At least I saw that the same variants failed on the stable branch.

@ChristianFeldmann ChristianFeldmann changed the base branch from stable to dev September 25, 2023 10:35
@ChristianFeldmann ChristianFeldmann merged commit 9c8b73a into dev Sep 25, 2023
6 checks passed
@ChristianFeldmann ChristianFeldmann deleted the docker-support branch September 25, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants