Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Added 'Ripple' to the list of supported clocking schemes #358

Merged
merged 4 commits into from
Dec 17, 2023

Conversation

marcelwa
Copy link
Collaborator

Description

This PR introduces support for the Ripple clocking scheme proposed in this thesis. It is an older scheme and we are only supporting it for the sake of completeness. As it turns out, exact has severe issues realizing even the simplest of functions using this scheme. It is not advised to use it. Rather use 2DDWave or USE.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@marcelwa marcelwa added the enhancement New feature or request label Dec 17, 2023
@marcelwa marcelwa self-assigned this Dec 17, 2023
Copy link

codecov bot commented Dec 17, 2023

Codecov Report

Merging #358 (fddaa90) into main (2e3446c) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #358      +/-   ##
==========================================
- Coverage   96.06%   96.05%   -0.01%     
==========================================
  Files         102      102              
  Lines       10107    10112       +5     
==========================================
+ Hits         9709     9713       +4     
- Misses        398      399       +1     
Files Coverage Δ
include/fiction/layouts/clocking_scheme.hpp 97.12% <100.00%> (+0.08%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e3446c...fddaa90. Read the comment docs.

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@marcelwa marcelwa merged commit 6d48b73 into main Dec 17, 2023
58 checks passed
@marcelwa marcelwa deleted the ripple-clocking-scheme branch December 17, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants