Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Include x_min and y_min in OpDomain and check non-emptyness of vector before accessing element. #407

Merged
merged 19 commits into from
Apr 16, 2024
Merged

🐛 Include x_min and y_min in OpDomain and check non-emptyness of vector before accessing element. #407

merged 19 commits into from
Apr 16, 2024

Conversation

Drewniok
Copy link
Collaborator

@Drewniok Drewniok commented Apr 12, 2024 •
edited
Loading

Description

This PR fixes a non-deterministic failure of the operational domain unit tests on Ubuntu and Windows. This is fixed by checking that moore_neighborhood is not empty before selecting the front step point. It also ensures that x_min and y_min are part of the parameter space that is checked for operation.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@Drewniok Drewniok marked this pull request as draft April 12, 2024 13:26
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@Drewniok Drewniok changed the title 🐛 include x_min and y_min in the opdomain. 🐛 Include x_min and y_min in OpDomain and check non-emptyness of vector before accessing element. Apr 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@Drewniok Drewniok added the bug Something isn't working label Apr 12, 2024
@Drewniok Drewniok self-assigned this Apr 12, 2024
@Drewniok Drewniok marked this pull request as ready for review April 12, 2024 14:44
@Drewniok Drewniok requested a review from marcelwa April 12, 2024 14:44
marcelwa
marcelwa reviewed Apr 13, 2024
View reviewed changes
Copy link
Collaborator

@marcelwa marcelwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for your time and effort looking into this. I'm not sure I understand what's going on, and require some further explanations, if you don't mind.

include/fiction/algorithms/simulation/sidb/operational_domain.hpp Outdated Show resolved Hide resolved
include/fiction/algorithms/simulation/sidb/operational_domain.hpp Show resolved Hide resolved
include/fiction/algorithms/simulation/sidb/operational_domain.hpp Outdated Show resolved Hide resolved
include/fiction/algorithms/simulation/sidb/operational_domain.hpp Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@Drewniok Drewniok requested review from marcelwa and removed request for marcelwa April 13, 2024 11:58
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@Drewniok Drewniok requested a review from marcelwa April 13, 2024 12:20
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

marcelwa
marcelwa requested changes Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@marcelwa marcelwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for the adjustments. Just some comments on consistency.

include/fiction/algorithms/simulation/sidb/operational_domain.hpp Outdated Show resolved Hide resolved
include/fiction/algorithms/simulation/sidb/operational_domain.hpp Outdated Show resolved Hide resolved
include/fiction/algorithms/simulation/sidb/operational_domain.hpp Outdated Show resolved Hide resolved
@Drewniok Drewniok requested a review from marcelwa April 15, 2024 09:56
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@codecov Codecov
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 96.80851% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 98.34%. Comparing base (5472969) to head (b6278e8).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #407      +/-   ##
==========================================
- Coverage   98.34%   98.34%   -0.01%     
==========================================
  Files         210      210              
  Lines       28040    28091      +51     
  Branches     1280     1285       +5     
==========================================
+ Hits        27576    27625      +49     
- Misses        464      466       +2
Files Coverage Δ
...fiction/technology/charge_distribution_surface.hpp 99.37% <100.00%> (+<0.01%) ⬆️
.../algorithms/simulation/sidb/operational_domain.cpp 100.00% <100.00%> (ø)
.../algorithms/simulation/sidb/operational_domain.hpp 96.77% <82.35%> (-0.81%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5472969...b6278e8. Read the comment docs.

marcelwa
marcelwa approved these changes Apr 16, 2024
View reviewed changes
Copy link
Collaborator

@marcelwa marcelwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks!! 🙏

@Drewniok Drewniok merged commit 386120a into cda-tum:main Apr 16, 2024
63 checks passed
@Drewniok Drewniok deleted the change_x_y_size_opdomain branch July 18, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelwa marcelwa marcelwa approved these changes

Assignees

@Drewniok Drewniok

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Drewniok @marcelwa