Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 Updated the Ubuntu CI to include 24.04 and newer compiler versions #466

Merged
merged 14 commits into from
Aug 16, 2024

Conversation

marcelwa
Copy link
Collaborator

Description

Dropped ubuntu-20.04 and added ubuntu-24.04. Additionally, updated the C++ compilers to newer versions

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have added a changelog entry.
  • I have created/adjusted the Python bindings for any new or updated functionality.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@marcelwa marcelwa added the github_actions Pull requests that update GitHub Actions code label Jun 28, 2024
@marcelwa marcelwa self-assigned this Jun 28, 2024
@marcelwa
Copy link
Collaborator Author

@Drewniok the build with GCC 14 fails here because of the convert_to_siqad_coordinates function. It is a GCC bug. Do you think, you could rewrite the function anyway to reduce nesting and return type inference to assist the compiler?

@marcelwa
Copy link
Collaborator Author

@Drewniok the build with GCC 14 fails here because of the convert_to_siqad_coordinates function. It is a GCC bug. Do you think, you could rewrite the function anyway to reduce nesting and return type inference to assist the compiler?

The issue occurs on macOS as well. See, e.g., here: https://github.com/cda-tum/fiction/actions/runs/10387750687/job/28761888544?pr=499

Hope that helps with reproducibility.

@Drewniok
Copy link
Collaborator

@Drewniok the build with GCC 14 fails here because of the convert_to_siqad_coordinates function. It is a GCC bug. Do you think, you could rewrite the function anyway to reduce nesting and return type inference to assist the compiler?
are al
@marcelwa Oh, that's not good. Sure, I'll have a look asap. I'll try my best, but this convert function has already caused me a lot of worries.

@marcelwa
Copy link
Collaborator Author

@Drewniok the build with GCC 14 fails here because of the convert_to_siqad_coordinates function. It is a GCC bug. Do you think, you could rewrite the function anyway to reduce nesting and return type inference to assist the compiler?
are al
@marcelwa Oh, that's not good. Sure, I'll have a look asap. I'll try my best, but this convert function has already caused me a lot of worries.

Understandable. It is not a simple function. I spent some time myself (maybe 30 min) and could not fix the issue. It probably requires dissecting the code a bit more.

@Drewniok
Copy link
Collaborator

@marcelwa Finally I could fix it! I am not sure where to put the code change. We can close #501 and change the title of #499 to make it clear that the code was also slightly changed. What do you think?

@marcelwa
Copy link
Collaborator Author

@marcelwa Finally I could fix it! I am not sure where to put the code change. We can close #501 and change the title of #499 to make it clear that the code was also slightly changed. What do you think?

Agreed. That would be good. Thank you so much for investigating the problem.

@marcelwa marcelwa merged commit 93da76b into main Aug 16, 2024
16 checks passed
@marcelwa marcelwa deleted the ubuntu-24.04-ci-update branch August 16, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants