-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Extended Time-to-Solution Function #500
Conversation
Signed-off-by: GitHub Actions <actions@github.com>
…mize_tts_function
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #500 +/- ##
==========================================
- Coverage 98.15% 98.14% -0.01%
==========================================
Files 224 224
Lines 31045 31133 +88
Branches 1549 1561 +12
==========================================
+ Hits 30471 30557 +86
- Misses 574 576 +2
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Signed-off-by: GitHub Actions <actions@github.com>
…mize_tts_function # Conflicts: # bindings/pyfiction/include/pyfiction/algorithms/simulation/sidb/time_to_solution.hpp
bindings/pyfiction/test/algorithms/simulation/sidb/test_time_to_solution.py
Outdated
Show resolved
Hide resolved
bindings/pyfiction/test/algorithms/simulation/sidb/test_time_to_solution.py
Outdated
Show resolved
Hide resolved
Signed-off-by: GitHub Actions <actions@github.com>
include/fiction/algorithms/simulation/sidb/time_to_solution.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: GitHub Actions <actions@github.com>
|
This happens occasionally. |
The log gives information on why. In this case, it seems that |
That's one possible explanation! Thanks! |
Description
This PR extends the time-to-solution (tts) calculation with a new function that can be used when simulation results are already available and we want to determine the tts based on those results.
Checklist: