Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Restructured Critical Temperature simulation with kink control option #573

Merged
merged 21 commits into from
Nov 16, 2024

Conversation

Drewniok
Copy link
Collaborator

Description

This PR restructures the Critical Temperature (CT) simulation. At the same time, it is now supported to set if kinks are allowed or forbidden for CT simulation.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have added a changelog entry.
  • I have created/adjusted the Python bindings for any new or updated functionality.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@Drewniok Drewniok added the enhancement New feature or request label Nov 12, 2024
@Drewniok Drewniok self-assigned this Nov 12, 2024
@Drewniok Drewniok changed the title ✨ Restructured critical temperature simulation with kink control option ✨ Restructured Critical Temperature simulation with kink control option Nov 12, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@Drewniok Drewniok requested a review from marcelwa November 13, 2024 08:42
@marcelwa
Copy link
Collaborator

marcelwa commented Nov 13, 2024

@Drewniok the CIs that have currently passed are not sufficient to ensure the robustness of this PR. They only ran the docstring and documentation generators.

Nevermind. After a reload of the page, it now shows me further runs.

@Drewniok Drewniok requested a review from marcelwa November 13, 2024 15:13
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 96.98113% with 8 lines in your changes missing coverage. Please review.

Project coverage is 98.09%. Comparing base (1e83a7d) to head (b80994a).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...lgorithms/simulation/sidb/critical_temperature.hpp 82.50% 7 Missing ⚠️
...tion/algorithms/simulation/sidb/is_operational.hpp 95.65% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #573      +/-   ##
==========================================
+ Coverage   98.07%   98.09%   +0.02%     
==========================================
  Files         230      232       +2     
  Lines       35180    35300     +120     
  Branches     1691     1701      +10     
==========================================
+ Hits        34503    34628     +125     
+ Misses        677      672       -5     
Files with missing lines Coverage Δ
...imulation/sidb/calculate_energy_and_state_type.hpp 100.00% <100.00%> (ø)
.../algorithms/simulation/sidb/verify_logic_match.hpp 100.00% <100.00%> (ø)
...hms/simulation/sidb/can_positive_charges_occur.cpp 100.00% <100.00%> (ø)
...lgorithms/simulation/sidb/critical_temperature.cpp 100.00% <100.00%> (ø)
test/algorithms/simulation/sidb/is_operational.cpp 100.00% <100.00%> (ø)
.../algorithms/simulation/sidb/operational_domain.cpp 99.23% <100.00%> (ø)
.../algorithms/simulation/sidb/verify_logic_match.cpp 100.00% <100.00%> (ø)
test/utils/blueprints/layout_blueprints.hpp 100.00% <ø> (ø)
...tion/algorithms/simulation/sidb/is_operational.hpp 94.70% <95.65%> (+6.50%) ⬆️
...lgorithms/simulation/sidb/critical_temperature.hpp 93.00% <82.50%> (-4.50%) ⬇️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5be31c...b80994a. Read the comment docs.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@Drewniok Drewniok requested a review from marcelwa November 15, 2024 14:50
Copy link
Collaborator

@marcelwa marcelwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for the cool addition and your work on the iterations! 🙏

@Drewniok
Copy link
Collaborator Author

Many thanks for the cool addition and your work on the iterations! 🙏

Thank you for your hard work to improve the usability! 🙏

@marcelwa marcelwa merged commit 735daab into cda-tum:main Nov 16, 2024
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants