-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Restructured Critical Temperature simulation with kink control option #573
✨ Restructured Critical Temperature simulation with kink control option #573
Conversation
Signed-off-by: GitHub Actions <actions@github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
.../algorithms/simulation/sidb/does_charge_distribution_match_logic_for_given_input_pattern.cpp
Outdated
Show resolved
Hide resolved
.../algorithms/simulation/sidb/does_charge_distribution_match_logic_for_given_input_pattern.cpp
Outdated
Show resolved
Hide resolved
.../algorithms/simulation/sidb/does_charge_distribution_match_logic_for_given_input_pattern.cpp
Outdated
Show resolved
Hide resolved
.../algorithms/simulation/sidb/does_charge_distribution_match_logic_for_given_input_pattern.cpp
Outdated
Show resolved
Hide resolved
…' into restructure_critical_temeprature
Signed-off-by: GitHub Actions <actions@github.com>
Nevermind. After a reload of the page, it now shows me further runs. |
include/fiction/algorithms/simulation/sidb/calculate_energy_and_state_type.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/simulation/sidb/critical_temperature.hpp
Outdated
Show resolved
Hide resolved
...iction/algorithms/simulation/sidb/does_charge_distribution_match_logic_for_input_pattern.hpp
Outdated
Show resolved
Hide resolved
...iction/algorithms/simulation/sidb/does_charge_distribution_match_logic_for_input_pattern.hpp
Outdated
Show resolved
Hide resolved
...iction/algorithms/simulation/sidb/does_charge_distribution_match_logic_for_input_pattern.hpp
Outdated
Show resolved
Hide resolved
.../algorithms/simulation/sidb/does_charge_distribution_match_logic_for_given_input_pattern.cpp
Outdated
Show resolved
Hide resolved
...iction/algorithms/simulation/sidb/does_charge_distribution_match_logic_for_input_pattern.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: GitHub Actions <actions@github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
include/fiction/algorithms/simulation/sidb/does_cds_match_logic_for_input_pattern.hpp
Outdated
Show resolved
Hide resolved
test/algorithms/simulation/sidb/does_cds_match_logic_for_given_input_pattern.cpp
Outdated
Show resolved
Hide resolved
test/algorithms/simulation/sidb/does_cds_match_logic_for_given_input_pattern.cpp
Outdated
Show resolved
Hide resolved
test/algorithms/simulation/sidb/does_cds_match_logic_for_given_input_pattern.cpp
Outdated
Show resolved
Hide resolved
test/algorithms/simulation/sidb/does_cds_match_logic_for_given_input_pattern.cpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/simulation/sidb/does_cds_match_logic_for_input_pattern.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/simulation/sidb/does_cds_match_logic_for_input_pattern.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/simulation/sidb/does_cds_match_logic_for_input_pattern.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/simulation/sidb/does_cds_match_logic_for_input_pattern.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/simulation/sidb/calculate_energy_and_state_type.hpp
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #573 +/- ##
==========================================
+ Coverage 98.07% 98.09% +0.02%
==========================================
Files 230 232 +2
Lines 35180 35300 +120
Branches 1691 1701 +10
==========================================
+ Hits 34503 34628 +125
+ Misses 677 672 -5
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Signed-off-by: GitHub Actions <actions@github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
include/fiction/algorithms/simulation/sidb/critical_temperature.hpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for the cool addition and your work on the iterations! 🙏
Thank you for your hard work to improve the usability! 🙏 |
Description
This PR restructures the Critical Temperature (CT) simulation. At the same time, it is now supported to set if kinks are allowed or forbidden for CT simulation.
Checklist: