Skip to content

Commit

Permalink
👷🔧🍎 enable Python 3.8+ tests on macos-14 runners (#597)
Browse files Browse the repository at this point in the history
## Description

GitHub's `macos-14` runners now also support Python 3.8 and 3.9. This PR
adjusts the reusable workflows to remove the special handling that was
in place previously.

## Checklist:

<!---
This checklist serves as a reminder of a couple of things that ensure
your pull request will be merged swiftly.
-->

- [x] The pull request only contains commits that are related to it.
- [x] I have added appropriate tests and documentation.
- [x] I have made sure that all CI jobs on GitHub pass.
- [x] The pull request introduces no new warnings and follows the
project's style guidelines.

Signed-off-by: burgholzer <burgholzer@me.com>
  • Loading branch information
burgholzer authored Apr 30, 2024
1 parent 8d0746c commit 8fbfaa5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/codecov.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ flag_management:
- name: python
paths:
- "src/mqt/**/*.py"
after_n_builds: 10
after_n_builds: 11
statuses:
- type: project
threshold: 0.5%
Expand Down
5 changes: 1 addition & 4 deletions .github/workflows/reusable-python-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,7 @@ jobs:
python-version:
- ${{ fromJson(needs.dist.outputs.python-versions)[0] }}
- ${{ needs.dist.outputs.max-python-version }}
runs-on: [macos-13] # test Intel architecture
include:
- runs-on: macos-14 # test Apple Silicon architecture
python-version: ${{ needs.dist.outputs.max-python-version }} # testing Apple Silicon on 3.8 is blocked by https://github.com/actions/setup-python/issues/808
runs-on: [macos-13, macos-14]
uses: ./.github/workflows/reusable-python-tests.yml
with:
runs-on: ${{ matrix.runs-on }}
Expand Down

0 comments on commit 8fbfaa5

Please sign in to comment.