Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix scientific notation in QASM import #560

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

burgholzer
Copy link
Member

Description

This PR fixes a small bug in the QASM importer that would prevent it from properly importing floating point numbers in scientific notation.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer added fix Fix for something that isn't working Core Anything related to the Core library and IR c++ Anything related to C++ code labels Mar 12, 2024
@burgholzer burgholzer self-assigned this Mar 12, 2024
Signed-off-by: burgholzer <burgholzer@me.com>
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.1%. Comparing base (a392c48) to head (76c6a04).

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #560   +/-   ##
=====================================
  Coverage   91.1%   91.1%           
=====================================
  Files        132     132           
  Lines      13794   13804   +10     
  Branches    2166    2171    +5     
=====================================
+ Hits       12573   12583   +10     
  Misses      1221    1221           
Flag Coverage Δ
cpp 90.8% <100.0%> (+<0.1%) ⬆️
python 99.5% <ø> (ø)
Files Coverage Δ
src/parsers/qasm3_parser/Scanner.cpp 96.8% <100.0%> (+<0.1%) ⬆️

@burgholzer burgholzer merged commit 414fe24 into main Mar 12, 2024
37 checks passed
@burgholzer burgholzer deleted the fix-qasm-import-scientific-notation branch March 12, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code Core Anything related to the Core library and IR fix Fix for something that isn't working
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant